fix: Speed up cache reads #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up
read.streamandreadby skippingfs.statcall ifsizewas passed viaopts. Currently, the only reason for doing astatcall is to get the size (and throw the size mismatch error if the size is different). This is unnecessary for 3 reasons:read.stream, the stream already compares the sizes at the end and throws an error if there's a mismatch.read, we can compare the sizes after reading the cache contentsIn this PR, the
statcall is only made if the user does not pass asizeproperty viaopts. This makes sense because without knowing thesize, the stream has to make an unnecessaryfs.readcall at the end before closing which has a significant cost (that cost is much, much greater than the cost of doingfs.stat).On my machine, the benchmarks with this change look like this:
That's a solid 16% improvement in the case of
read.streamand 36% improvement in the case ofread.References